From 97d862a4b2277beb393cc57d2532d54f9c6fb7d1 Mon Sep 17 00:00:00 2001 From: Anthony Ryan Date: Thu, 20 Dec 2012 16:39:10 -0500 Subject: [PATCH 1/3] Specify the precise version of IE referenced in this problem --- jquery.flot.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/jquery.flot.js b/jquery.flot.js index 19de082..7988853 100644 --- a/jquery.flot.js +++ b/jquery.flot.js @@ -955,7 +955,7 @@ Licensed under the MIT license. // accept various kinds of newlines, including HTML ones // (you can actually split directly on regexps in Javascript, - // but IE is unfortunately broken) + // but IE < 9 is unfortunately broken) var lines = (t.label + "").replace(/
|\r\n|\r/g, "\n").split("\n"); for (var j = 0; j < lines.length; ++j) { var line = { text: lines[j] }, From 50a45ba99503415f9805bd50598f819f31869b52 Mon Sep 17 00:00:00 2001 From: Anthony Ryan Date: Thu, 20 Dec 2012 16:43:00 -0500 Subject: [PATCH 2/3] Remove Internet Explorer specific code, that appears to have no impact on actual rendering see bug #905 --- jquery.flot.pie.js | 2 -- 1 file changed, 2 deletions(-) diff --git a/jquery.flot.pie.js b/jquery.flot.pie.js index 5c19404..8a04533 100644 --- a/jquery.flot.pie.js +++ b/jquery.flot.pie.js @@ -426,8 +426,6 @@ More detail and specific examples can be found in the included HTML file. ctx.beginPath(); if (Math.abs(angle - Math.PI * 2) > 0.000000001) { ctx.moveTo(0, 0); // Center of the pie - } else if ($.browser.msie) { - angle -= 0.0001; } //ctx.arc(0, 0, radius, 0, angle, false); // This doesn't work properly in Opera From a4ac13085c297be040f36f94dc3cdfcebf0c1d86 Mon Sep 17 00:00:00 2001 From: Anthony Ryan Date: Thu, 20 Dec 2012 18:14:25 -0500 Subject: [PATCH 3/3] Document the affected versions of opera, and replace $.browser.opera with a line to detect only affected versions --- jquery.flot.js | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/jquery.flot.js b/jquery.flot.js index 7988853..3c96a6c 100644 --- a/jquery.flot.js +++ b/jquery.flot.js @@ -1749,8 +1749,10 @@ Licensed under the MIT license. y += line.height/2 + offset; offset += line.height; - if ($.browser.opera) { - // FIXME: UGLY BROWSER DETECTION + if (!!(window.opera && window.opera.version().split('.')[0] < 12)) { + // FIXME: LEGACY BROWSER FIX + // AFFECTS: Opera < 12.00 + // round the coordinates since Opera // otherwise switches to more ugly // rendering (probably non-hinted) and