Commit Graph

607 Commits (cfc07ff28588a15ff06a04bb0aa6287e1694b308)
 

Author SHA1 Message Date
David Schnur cfc07ff285 Eliminate the plugin-global redraw flag.
The redraw flag starts out as true, then is immediately set to false on
draw.  If labels are enabled, drawPie calls drawLabels, which calls
drawLabel for each label.  Any label that can't fit sets redraw back to
true, so the whole process can repeat.

This isn't the most obvious mechanism, and forces one to remember to do
things like setting redraw back to true after drawing, so the plot can
redraw itself on resize or when setting new data.

Instead we now have drawPie return true when it drew successfully, and
false otherwise, which the same happening in drawLabels and drawLabel.
Instead of checking the flag, we now just check the return value.

This has the added benefit of slightly improving performance in the case
where several redraws are necessary, since it now short-circuits out of
the draw loop as soon as one label fails to fit.
13 years ago
David Schnur fa463311dc Make redrawAttempts and shrink proper constants. 13 years ago
David Schnur 778894324d Make the slice total a local variable.
The total is only used within the combine function; it doesn't need to
exist at the top level of the plugin.
13 years ago
David Schnur a1c84203bd Moved fixData and calcData into combine.
They're small and not used anywhere else, so keeping them in separate
functions only serves to increase complexity.
13 years ago
David Schnur a03c4c199d Moved other hooks out of the processOptions hook.
In plugins we should never add hooks conditionally; the condition should
remain within individual hooks, so the plugin can be toggled at any
time.

Ideally we should also 'inline' the hook functions, since they're used
nowhere else.  But since that would involve a lot of code changes, we'll
put it off until the broader cleanup effort scheduled for 0.9.0.
13 years ago
David Schnur f294bf19a3 Cleaned up processOptions and bindEvents hooks. 13 years ago
David Schnur aaf41ea411 Fix placeholders for examples with other content.
After shrinking the global example placeholder size, ones with
additional content within the demo area needed to be tweaked
individually, to prevent the other content from wrapping down or
extending off the side of the container.
13 years ago
David Schnur b475c7219e Slightly reduce placeholder and header sizes.
The smaller size ensures that the example plots remain fully visible on
more of our most common visitor screen resolutions.
13 years ago
David Schnur bcce4a48b5 Load the first AJAX series by default.
We don't want users to think the example is broken when they first load
it.
13 years ago
David Schnur 840937cf33 Updated path to the timezone example.
The location of the file changed during the recent example revamp.
13 years ago
David Schnur a2cbc3a6be Load timezones asynchronously.
This prevents the Chicago example from showing up blank.  The
alternative is to define a callback, but that's messier.
13 years ago
David Schnur 23005fdd4e Move placeholder styles into .demo-placeholder.
This allows a page to have multiple placeholders, since we're no longer
tied to unique IDs.
13 years ago
David Schnur ec168da2cb Merge pull request #942 from sejordan/tickformatter-bug
Fix incorrect display of NaN with the default tickFormatter.
13 years ago
Sean Jordan f6f764eb2d Fixing bug with default tickFormatter
Change-Id: If53fdb1bf9563834c58cf2b569d0e1a6a7155eb8
13 years ago
David Schnur b637d67b9b Merge pull request #940 from dnschnur/better-examples
Revamped the built-in examples.
13 years ago
David Schnur e08ec95749 Updated examples index page styles. 13 years ago
David Schnur 713ba7704a Update example index page links for nesting. 13 years ago
David Schnur a2718dbee6 Add the Flot version to each example's footer. 13 years ago
David Schnur 79c3e25fe6 Allow live resizing in the resize example. 13 years ago
David Schnur ab7eb27c43 Flatten pie button styles so they fit in better. 13 years ago
David Schnur cf9cb4296c Fix the pie interactivity example. 13 years ago
David Schnur 61a13d1059 Additional code & comments cleanup. 13 years ago
David Schnur 492e97eacc Avoid being too specific in placeholder styles. 13 years ago
David Schnur ed791745c7 Re-styled and cleaned up all the examples. 13 years ago
David Schnur 8e8327f5d9 Add a sub-header style for per-plot labels. 13 years ago
David Schnur 0f23d23118 Pad check boxes to match the new page font size. 13 years ago
David Schnur 2eccabcf8c Generalize placeholder styles.
Give any direct child of demo-containre the same style, so it can be
used for both #placeholder and #overview.
13 years ago
David Schnur eeb1b9df28 Expand inputs to match the new page font size. 13 years ago
David Schnur 8a1180579c Expand buttons to match the new page font size. 13 years ago
David Schnur e05f390040 Fix plot legend padding.
Added explicit border-spacing to compensate for global removal of
padding.  Flot should really take care of this itself; layout-critical
styles shouldn't depend on the user-agent defaults.
13 years ago
David Schnur 6bdc88c1f9 Beautified CSS used by the examples pages.
Slightly widened the page to account for the fact that most people have
widescreen monitors these days.  Also made text larger and more legible,
and created a nice 'clipping' effect for the placeholder.
13 years ago
David Schnur a4ad4707d5 Updated credits for #934 threshold overlapping. 13 years ago
David Schnur 7e27b6d238 Merge pull request #934 from NIA/threshold-fixes
flot.threshold: insert generated series after original, not in the end
13 years ago
David Schnur 21e252ea8f Renamed layout.css to examples.css. 13 years ago
David Schnur 707c8ed845 Reorganized examples into subdirectories.
To improve organization with the increasing number of examples, every
example page is now the index of its own subdirectory, which contains
all the files specific to that example.
13 years ago
Ivan Novikov 17ceb51d91 flot.threshold: insert generated series after original, not in the end
Thus, prevent it from becoming topmost (it may cause strange looks if
original series is not topmost: some part of it becomes topmost and
overwrites some lines and points that should be above it instead).
13 years ago
David Schnur 36bfcbf08a Merge pull request #929 from hizhengfu/master
Fix an error in plot offset calculation.
13 years ago
hizhengfu 3c1d04cbd1 Correction calculation error margin
Correction calculation error margin
13 years ago
David Schnur f06fe931ea Merge pull request #861 from thecountofzero/master
Ensure that tickSize updates on subsequent calls to setupGrid.
13 years ago
David Schnur 92a833ce00 Cleaned up jQuery plugins site manifest.
Fixed jQuery version dependency (we require 1.2.6, not 1.3.2) and
whitespace.
13 years ago
David Schnur 4df443bd00 Updated Bower component.json version info.
Flot's semver is 0.8.0-alpha, and it (for now) requires jQuery 1.2.6,
not 1.3.2.
13 years ago
David Schnur a665f6793c Merge pull request #843 from ralphholzmann/bower
Adding component.json for bower.
13 years ago
David Schnur a60dbbfd1f Updated credits for sub-pixel rendering fixes. 13 years ago
David Schnur 29476b8911 Merge pull request #911 from dnschnur/series-zero-option
Added a series 'zero' option to control automatic scaling.
13 years ago
David Schnur be6fc4e41d Draw selection on half-pixels to avoid aliasing.
Adapted from pull request #17.
13 years ago
David Schnur 4a35faff61 Merge pull request #925 from danxshap/master
Always draw crosshair on half-pixels to prevent aliasing.
13 years ago
Daniel Shapiro 1bee76632d Draw crosshair on half-pixels to prevent aliasing 13 years ago
David Schnur 620b05a7e1 Merge pull request #923 from NIA/patch-1
Add passing offsets over plotpan event
13 years ago
David Schnur 2c64f82a4f Added the new 'zero' option to the changelog. 13 years ago
David Schnur 151e96fb27 Expand documentation of the point format options. 13 years ago